Skip to content

Location of the "mainProject" file #2

Open

Description

@JasonHK

Shouldn't be better this file stored in the parent project instead of one level of folders up? I think it may cause problems in some cases.

val coreProjectFile = project.file("../mainProject")

Activity

  1. Johni0702 commented on Aug 13, 2020

    @Johni0702
    Member

    Yeah, it could cause problems if you don't have all your versions in the same folder (one plausible example would be someone wanting to support Fabric and Forge with a structure like fabric/1.15.2/, fabric/1.16.2/, forge/1.15.2/, forge/1.16.2/).
    Merely having it be relative to the parent project would then introduce a different assumption though: the RM places the file relative to the root project at versions/mainProject, while the above example would likely prefer it to be at ./mainProject.

    Ideally the location of that file should just be configurable via the parent project's RootPreprocessExtension (defaulting to the current behavior of placing it one folder up from one of the sub-projects).

  2. added a commit that references this issue on Jul 14, 2024
    280ca72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions