Cherry-Pick Remove redundant _has_main_screen() overrides

[JoltedJon]

Semi-related Subtask of #1473
Pulls in godotengine/godot#117393

Summary by CodeRabbit

• Editor
  • Editor plugins for animation, audio, debugging, 2D and 3D scenes, shaders, navigation, OpenXR, and other tools now follow the editor’s inherited main-screen behavior rather than explicitly opting out.
  • The editor’s main-screen availability is also determined by its inherited behavior.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: Redot-Engine/redot-engine/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1499cafe-d773-4eae-b045-354fe8134712

📥 Commits

Reviewing files that changed from the base of the PR and between 80d31f7 and c804937.

📒 Files selected for processing (37)

• editor/animation/animation_player_editor_plugin.h
• editor/animation/animation_tree_editor_plugin.h
• editor/audio/audio_stream_randomizer_editor_plugin.h
• editor/audio/editor_audio_buses.h
• editor/debugger/debugger_editor_plugin.h
• editor/editor_node.h
• editor/scene/2d/abstract_polygon_2d_editor.h
• editor/scene/2d/parallax_background_editor_plugin.h
• editor/scene/2d/path_2d_editor_plugin.h
• editor/scene/2d/physics/cast_2d_editor_plugin.h
• editor/scene/2d/physics/collision_shape_2d_editor_plugin.h
• editor/scene/2d/skeleton_2d_editor_plugin.h
• editor/scene/2d/sprite_2d_editor_plugin.h
• editor/scene/3d/camera_3d_editor_plugin.h
• editor/scene/3d/gpu_particles_collision_sdf_editor_plugin.h
• editor/scene/3d/lightmap_gi_editor_plugin.h
• editor/scene/3d/mesh_instance_3d_editor_plugin.h
• editor/scene/3d/mesh_library_editor_plugin.h
• editor/scene/3d/multimesh_editor_plugin.h
• editor/scene/3d/occluder_instance_3d_editor_plugin.h
• editor/scene/3d/path_3d_editor_plugin.h
• editor/scene/3d/polygon_3d_editor_plugin.h
• editor/scene/3d/skeleton_3d_editor_plugin.h
• editor/scene/3d/skeleton_ik_3d_editor_plugin.h
• editor/scene/3d/voxel_gi_editor_plugin.h
• editor/scene/gui/theme_editor_plugin.h
• editor/scene/resource_preloader_editor_plugin.h
• editor/scene/sprite_frames_editor_plugin.h
• editor/shader/shader_file_editor_plugin.h
• modules/gltf/editor/editor_scene_exporter_gltf_plugin.cpp
• modules/gltf/editor/editor_scene_exporter_gltf_plugin.h
• modules/gridmap/editor/grid_map_editor_plugin.h
• modules/navigation_2d/editor/navigation_link_2d_editor_plugin.h
• modules/navigation_3d/editor/navigation_link_3d_editor_plugin.h
• modules/navigation_3d/editor/navigation_obstacle_3d_editor_plugin.h
• modules/navigation_3d/editor/navigation_region_3d_editor_plugin.h
• modules/openxr/editor/openxr_editor_plugin.h

💤 Files with no reviewable changes (37)

• editor/scene/3d/path_3d_editor_plugin.h
• editor/scene/3d/skeleton_3d_editor_plugin.h
• editor/audio/audio_stream_randomizer_editor_plugin.h
• modules/navigation_3d/editor/navigation_region_3d_editor_plugin.h
• editor/editor_node.h
• editor/scene/2d/parallax_background_editor_plugin.h
• editor/animation/animation_player_editor_plugin.h
• modules/navigation_2d/editor/navigation_link_2d_editor_plugin.h
• editor/scene/3d/polygon_3d_editor_plugin.h
• editor/scene/2d/abstract_polygon_2d_editor.h
• editor/scene/gui/theme_editor_plugin.h
• editor/scene/resource_preloader_editor_plugin.h
• editor/scene/3d/voxel_gi_editor_plugin.h
• editor/scene/2d/physics/cast_2d_editor_plugin.h
• editor/scene/3d/mesh_library_editor_plugin.h
• editor/scene/2d/path_2d_editor_plugin.h
• editor/scene/3d/lightmap_gi_editor_plugin.h
• editor/scene/2d/physics/collision_shape_2d_editor_plugin.h
• editor/audio/editor_audio_buses.h
• modules/gltf/editor/editor_scene_exporter_gltf_plugin.cpp
• editor/scene/2d/sprite_2d_editor_plugin.h
• editor/scene/sprite_frames_editor_plugin.h
• editor/scene/3d/skeleton_ik_3d_editor_plugin.h
• modules/openxr/editor/openxr_editor_plugin.h
• modules/gltf/editor/editor_scene_exporter_gltf_plugin.h
• editor/animation/animation_tree_editor_plugin.h
• modules/navigation_3d/editor/navigation_link_3d_editor_plugin.h
• modules/navigation_3d/editor/navigation_obstacle_3d_editor_plugin.h
• editor/scene/2d/skeleton_2d_editor_plugin.h
• editor/shader/shader_file_editor_plugin.h
• editor/scene/3d/mesh_instance_3d_editor_plugin.h
• editor/scene/3d/multimesh_editor_plugin.h
• editor/scene/3d/gpu_particles_collision_sdf_editor_plugin.h
• modules/gridmap/editor/grid_map_editor_plugin.h
• editor/scene/3d/occluder_instance_3d_editor_plugin.h
• editor/debugger/debugger_editor_plugin.h
• editor/scene/3d/camera_3d_editor_plugin.h

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

Walkthrough

The change removes has_main_screen() methods from EditorNode and editor plugins in the editor, GLTF, GridMap, navigation, and OpenXR modules.

Changes

Main-screen method removal

Layer / File(s)

Summary

Remove main-screen methods editor/editor_node.h, editor/animation/*_editor_plugin.h, editor/audio/*, editor/debugger/*, editor/scene/2d/..., editor/scene/3d/..., editor/scene/gui/theme_editor_plugin.h, editor/scene/resource_preloader_editor_plugin.h, editor/scene/sprite_frames_editor_plugin.h, editor/shader/shader_file_editor_plugin.h, modules/gltf/editor/..., modules/gridmap/editor/..., modules/navigation_2d/editor/..., modules/navigation_3d/editor/..., modules/openxr/editor/...

Removed plugin overrides of has_main_screen() that returned false. Removed EditorNode::has_main_screen(), which returned true.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: arctis-fireblight, decryptedchaos

Merge Risk: ⚪ Minimal · up to c8049

No behavior change or actionable merge risk was identified; the change is ready for normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: removing redundant _has_main_screen() overrides across editor plugins.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}