Repository navigation
Conversation
|
I think this PR requires the expertise of @florkbr |
petrsimon
force-pushed
the
fix/RHCLOUD-51591-ephemeral-api-graphql
branch
from
September 25, 2026 12:45
4e6f2a5 to
87778aa
Compare
petrsimon
changed the title
petrsimon
changed the title
Contributor
Author
|
Hi @bsquizz I was told that you might help with this, would be so kind and take a look. More details in the ticket. |
florkbr
reviewed
Sep 28, 2026
| "api.console", | ||
| "api.ask_red_hat" | ||
| "api.ask_red_hat", | ||
| "api.graphql" |
Contributor
There was a problem hiding this comment.
@petrsimon FWIW I was here a few years ago when we added the ARH integration: #1339. I added the new scope in a few more locations (defaultClientScopes appears numerous times) than what you've done here - so I'd just confirm we don't have any gaps.
Contributor
Author
There was a problem hiding this comment.
Good catch, @florkbr, done, kindly take a look.
petrsimon
force-pushed
the
fix/RHCLOUD-51591-ephemeral-api-graphql
branch
from
September 29, 2026 09:08
87778aa to
9c6fe22
Compare
petrsimon
changed the title
3 of 5 tasks
Define api.graphql as a client scope and assign it by default to cloud-services in the redhat-external realm import. https://issues.redhat.com/browse/RHCLOUD-51591 Co-Authored-By: gpt-6-luna <noreply@pi.dev>
petrsimon
force-pushed
the
fix/RHCLOUD-51591-ephemeral-api-graphql
branch
from
September 29, 2026 09:34
9c6fe22 to
d36215f
Compare
florkbr
approved these changes
Sep 29, 2026
florkbr
left a comment
florkbr
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me now 
We will need someone from clowder to review/merge.
Contributor
|
Grype failures addressed in another PR: #1820 |
Contributor
bsquizz
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses https://issues.redhat.com/browse/RHCLOUD-51591 by adding
api.graphqlto the ephemeral realm.The failing Anchore Grype check is pre-existing (same findings on the base commit) and tracked separately in https://issues.redhat.com/browse/RHCLOUD-51617.
Validation
make test— passedmake pre-push— passedgolangci-lintnot run: unavailable locally.Assisted by: Pi — gpt-6-luna max