[pull] main from MetaMask:main - #185
Merged
Merged
Conversation
…for when creating group (#6759) ## Explanation ```md - Add an optional `options` parameter to `MultichainAccountWallet.createMultichainAccountGroup()` - Introduces `options.waitForAllProvidersToFinishCreatingAccounts`, that will make `createMultichainAccountGroup` await either only the EVM provider or all the providers to have created their accounts depending on the value. Defaults to `false` (only awaits for EVM accounts creation by default). ``` ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds an `options.waitForAllProvidersToFinishCreatingAccounts` flag to `createMultichainAccountGroup`, defaulting to awaiting only EVM, and updates `createNextMultichainAccountGroup` to await all. > > - **Multichain Account Service**: > - **`createMultichainAccountGroup`**: > - Add optional `options` with `waitForAllProvidersToFinishCreatingAccounts` (default `false`). > - If `true`: await all providers via `Promise.allSettled`; throw on any failure with aggregated warnings. > - If `false` (default): await EVM provider; start other providers in background, log but ignore their errors. > - Update JSDoc for parameters and error semantics. > - **`createNextMultichainAccountGroup`**: now calls `createMultichainAccountGroup` with `waitForAllProvidersToFinishCreatingAccounts: true`. > - **Tests**: add coverage for failure when waiting for all providers; adjust non-EVM background behavior test. > - **Changelog**: document new `options` parameter and behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 403d744. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps monorepo to 597.0.0 and upgrades `@metamask/transaction-controller` to `60.6.0` (new messenger actions and shield subscription tx type), propagating the bump across dependent packages. > > - **Versioning** > - Bump root `version` to `597.0.0`. > - **Transaction Controller `60.6.0`** > - Add messenger actions: expose `addTransaction` and `addTransactionBatch`. > - Add new `shieldSubscriptionApprove` transaction type. > - Update `CHANGELOG.md` links and release entry. > - **Dependency updates** > - Upgrade `@metamask/transaction-controller` to `^60.6.0` in: `packages/assets-controllers`, `packages/bridge-controller`, `packages/bridge-status-controller`, `packages/earn-controller`, `packages/eip-5792-middleware`, `packages/network-enablement-controller`, `packages/phishing-controller`, `packages/shield-controller`, `packages/user-operation-controller`. > - Update `yarn.lock` accordingly. > - **Docs** > - Update `packages/eip-5792-middleware/CHANGELOG.md` to reflect `transaction-controller` bump. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ec4f40a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
Minor release of the `multichain-account-service` to introduce a new optional option when creating multichain account groups. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release multichain-account-service v1.5.0 with a new optional options param for createMultichainAccountGroup, update dependents, and bump monorepo version. > > - **multichain-account-service**: > - Version bump: `1.4.0` → `1.5.0` in `packages/multichain-account-service/package.json`. > - Changelog: add `1.5.0` entry documenting optional `options` for `MultichainAccountWallet.createMultichainAccountGroup()` and update compare links in `CHANGELOG.md`. > - **Dependents**: > - Update devDependency `@metamask/multichain-account-service` to `^1.5.0` in `packages/account-tree-controller/package.json` and `packages/assets-controllers/package.json`. > - **Repo**: > - Bump root `package.json` version to `598.0.0`. > - Update `yarn.lock` to reflect new `@metamask/multichain-account-service@^1.5.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 84ff221. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )