Repository navigation
fix(partition): deprecate partition operator and create partition sta… - #4685
Merged
Merged
Conversation
Contributor
Author
|
I am still working on the tests. |
dzhavat
reviewed
Apr 4, 2019
| * ```ts | ||
| * import { partition } from 'rxjs'; | ||
| * | ||
| * const observableValues = of(1, 2, 3, 4, 5, 6); |
dzhavat
reviewed
Apr 4, 2019
| * | ||
| * odds$.subscribe(x => console.log('odds', x)); | ||
| * evens$.subscribe(x => console.log('evens', x)); | ||
| * ``` |
Contributor
There was a problem hiding this comment.
It'd be nice to have the outputs of odds$ and evens$.
benlesh
requested changes
Apr 4, 2019
benlesh
left a comment
benlesh
left a comment
Member
There was a problem hiding this comment.
Will also need tests and dtslint tests.
| * with values that passed the predicate, and another with values that did not | ||
| * pass the predicate. | ||
| * @method partition | ||
| * @owner Observable |
Member
There was a problem hiding this comment.
@method and @owner can be removed. That's legacy from our old docs system.
Member
|
(I can see it's draft, but it's looking good so far) |
dkosasih
force-pushed
the
partition-fix
branch
2 times, most recently
from
April 11, 2019 05:03
2669cc7 to
b2cbdac
Compare
dkosasih
marked this pull request as ready for review
April 11, 2019 05:05
Contributor
Author
|
It seems like there are few dtslint tests that are failing. |
Pull Request Test Coverage Report for Build 8349
💛 - Coveralls |
benlesh
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate the current
partitionoperator and create a new creation function partition observable.Related issue (if exists):
#4419