Skip to content

fix(throttleTime): fix trailing - #4491

Closed
devel112 wants to merge 2 commits into
ReactiveX:masterfrom
devel112:master
Closed

fix(throttleTime): fix trailing#4491
devel112 wants to merge 2 commits into
ReactiveX:masterfrom
devel112:master

Conversation

@devel112

@devel112 devel112 commented Jan 24, 2019

Copy link
Copy Markdown

Description:
Emitting a trailing value should be counted as emitting a value.

Commit that introduced bug

Related issue (if exists):
#2859

@ci-reporter

ci-reporter Bot commented Jan 24, 2019 •
edited
Loading

Copy link
Copy Markdown

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 68245a0. Here's the output:

npm test
> @reactivex/rxjs@6.3.3 test /home/travis/build/ReactiveX/rxjs
> cross-env TS_NODE_PROJECT=spec/tsconfig.json mocha --opts spec/support/default.opts "spec/**/*-spec.ts"



  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․,,,․․․,․․․․․․․․���․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․!․!!․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․���․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․

  2593 passing (4s)
  4 pending
  3 failing

  1) throttleTime operator
       throttleTime(fn, { leading: true, trailing: true })
         should immediately emit the first value in each time window:
     AssertionError: 
Expected 
	{"frame":10,"notification":{"kind":"N","value":"a","hasValue":true}}
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":100,"notification":{"kind":"N","value":"b","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":180,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}
	
to deep equal 
	{"frame":10,"notification":{"kind":"N","value":"a","hasValue":true}}
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":100,"notification":{"kind":"N","value":"b","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":160,"notification":{"kind":"N","value":"c","hasValue":true}}
	{"frame":200,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}

      at TestScheduler.observableMatcher [as assertDeepEqual] (spec/helpers/testScheduler-ui.ts:185:14)
      at src/internal/testing/TestScheduler.ts:159:14
      at Array.filter (<anonymous>)
      at TestScheduler.flush (src/internal/testing/TestScheduler.ts:157:39)
      at Context.modified (spec/helpers/testScheduler-ui.ts:207:37)

  2) throttleTime operator
       throttleTime(fn, { leading: false, trailing: true })
         should immediately emit the first value in each time window:
     AssertionError: 
Expected 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":180,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}
	
to deep equal 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":200,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}

      at TestScheduler.observableMatcher [as assertDeepEqual] (spec/helpers/testScheduler-ui.ts:185:14)
      at src/internal/testing/TestScheduler.ts:159:14
      at Array.filter (<anonymous>)
      at TestScheduler.flush (src/internal/testing/TestScheduler.ts:157:39)
      at Context.modified (spec/helpers/testScheduler-ui.ts:207:37)

  3) throttleTime operator
       throttleTime(fn, { leading: false, trailing: true })
         should emit the last throttled value when complete:
     AssertionError: 
Expected 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":180,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":190,"notification":{"kind":"C","hasValue":false}}
	
to deep equal 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":190,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":190,"notification":{"kind":"C","hasValue":false}}

      at TestScheduler.observableMatcher [as assertDeepEqual] (spec/helpers/testScheduler-ui.ts:185:14)
      at src/internal/testing/TestScheduler.ts:159:14
      at Array.filter (<anonymous>)
      at TestScheduler.flush (src/internal/testing/TestScheduler.ts:157:39)
      at Context.modified (spec/helpers/testScheduler-ui.ts:207:37)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for 0954f9f
npm test
> @reactivex/rxjs@6.3.3 test /home/travis/build/ReactiveX/rxjs
> cross-env TS_NODE_PROJECT=spec/tsconfig.json mocha --opts spec/support/default.opts "spec/**/*-spec.ts"



  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․,,,․․․,․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․!!!․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․���
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․

  2592 passing (4s)
  4 pending
  3 failing

  1) throttleTime operator
       throttleTime(fn, { leading: true, trailing: true })
         should immediately emit the first value in each time window:
     AssertionError: 
Expected 
	{"frame":10,"notification":{"kind":"N","value":"a","hasValue":true}}
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":100,"notification":{"kind":"N","value":"b","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":180,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}
	
to deep equal 
	{"frame":10,"notification":{"kind":"N","value":"a","hasValue":true}}
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":100,"notification":{"kind":"N","value":"b","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":160,"notification":{"kind":"N","value":"c","hasValue":true}}
	{"frame":200,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}

      at TestScheduler.observableMatcher [as assertDeepEqual] (spec/helpers/testScheduler-ui.ts:185:14)
      at src/internal/testing/TestScheduler.ts:159:14
      at Array.filter (<anonymous>)
      at TestScheduler.flush (src/internal/testing/TestScheduler.ts:157:39)
      at Context.modified (spec/helpers/testScheduler-ui.ts:207:37)

  2) throttleTime operator
       throttleTime(fn, { leading: false, trailing: true })
         should immediately emit the first value in each time window:
     AssertionError: 
Expected 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":180,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}
	
to deep equal 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":200,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":220,"notification":{"kind":"C","hasValue":false}}

      at TestScheduler.observableMatcher [as assertDeepEqual] (spec/helpers/testScheduler-ui.ts:185:14)
      at src/internal/testing/TestScheduler.ts:159:14
      at Array.filter (<anonymous>)
      at TestScheduler.flush (src/internal/testing/TestScheduler.ts:157:39)
      at Context.modified (spec/helpers/testScheduler-ui.ts:207:37)

  3) throttleTime operator
       throttleTime(fn, { leading: false, trailing: true })
         should emit the last throttled value when complete:
     AssertionError: 
Expected 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":180,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":190,"notification":{"kind":"C","hasValue":false}}
	
to deep equal 
	{"frame":50,"notification":{"kind":"N","value":"y","hasValue":true}}
	{"frame":140,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":190,"notification":{"kind":"N","value":"x","hasValue":true}}
	{"frame":190,"notification":{"kind":"C","hasValue":false}}

      at TestScheduler.observableMatcher [as assertDeepEqual] (spec/helpers/testScheduler-ui.ts:185:14)
      at src/internal/testing/TestScheduler.ts:159:14
      at Array.filter (<anonymous>)
      at TestScheduler.flush (src/internal/testing/TestScheduler.ts:157:39)
      at Context.modified (spec/helpers/testScheduler-ui.ts:207:37)
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

cartant
cartant requested changes Jan 25, 2019
View reviewed changes

@cartant cartant left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR addresses a bug, could you please add a failing test that passes when this change in made? And the failing tests will need to be addressed. If this change effects test failures, it's going to be a breaking, behavioral change.

@devel112

devel112 commented Jan 25, 2019

Copy link
Copy Markdown
Author

Having trouble making a test for { leading: true, trailing true } because an active task needs to be flushed on _next, i think. Maybe the scheduled task is queued for execution after _next in the tests.

MatthiasKunnen added a commit to MatthiasKunnen/rxjs that referenced this pull request Feb 14, 2019
@MatthiasKunnen
fix(throttleTime): fix single value with leading disabled, trailing e…
0cbbbae 
…nabled

Emit single value with leading disabled, trailing enabled.

Closes ReactiveX#2859 and ReactiveX#4491.
@MatthiasKunnen MatthiasKunnen mentioned this pull request Feb 14, 2019
Merged
benlesh pushed a commit that referenced this pull request Apr 23, 2019
@MatthiasKunnen @benlesh
fix(throttleTime): emit single value with trailing enabled (#4564)
fd690a6 
* test(throttleTime): test single value with trailing enabled

Test if throttleTime emits when only a single value is emitted from the
source with leading enabled/disabled and trailing enabled.

* fix(throttleTime): fix single value with leading disabled, trailing enabled

Emit single value with leading disabled, trailing enabled.

Closes #2859 and #4491.

* chore: improve test descriptions

And remove an asDiagram call made with the same argument.

Signed-off-by: Matthias Kunnen <matthias.kunnen@gmail.com>
@MatthiasKunnen

MatthiasKunnen commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

This PR can be closed since the issue has been addressed in PR #4564.

@cartant cartant closed this Apr 23, 2019
BioPhoton pushed a commit to BioPhoton/rxjs that referenced this pull request May 15, 2019
@MatthiasKunnen @BioPhoton
fix(throttleTime): emit single value with trailing enabled (ReactiveX…
c2255a9 
…#4564)

* test(throttleTime): test single value with trailing enabled

Test if throttleTime emits when only a single value is emitted from the
source with leading enabled/disabled and trailing enabled.

* fix(throttleTime): fix single value with leading disabled, trailing enabled

Emit single value with leading disabled, trailing enabled.

Closes ReactiveX#2859 and ReactiveX#4491.

* chore: improve test descriptions

And remove an asDiagram call made with the same argument.

Signed-off-by: Matthias Kunnen <matthias.kunnen@gmail.com>
@lock lock Bot locked as resolved and limited conversation to collaborators May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cartant cartant cartant requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devel112 @MatthiasKunnen @cartant