Translate Chat Completions tool_choice to the Responses API shape - #129
Open
jaydenireland wants to merge 1 commit into
Open
jaydenireland wants to merge 1 commit into
jaydenireland wants to merge 1 commit into
Conversation
Closes RayBytes#128. Forced tool choices sent as {"type":"function","function":{"name":...}} were forwarded to the Responses API untouched, which rejects them with "Missing required parameter: 'tool_choice.name'". "required" was also outside the allowed string list and silently downgraded to "auto". Add convert_tool_choice_chat_to_responses in utils.py, use it in both the OpenAI and Ollama routes (including the responses_tools retry path), and accept "required" in start_upstream_request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128.
Forced tool choices sent as {"type":"function","function":{"name":...}} were forwarded to the Responses API untouched, which rejects them with "Missing required parameter: 'tool_choice.name'". "required" was also outside the allowed string list and silently downgraded to "auto".
Add convert_tool_choice_chat_to_responses in utils.py, use it in both the OpenAI and Ollama routes (including the responses_tools retry path), and accept "required" in start_upstream_request.