Skip to content

Potential bug in non-polarised custom XY #218

Description

@DrPaulSharp

In the non-polarised custom XY routines, we have (line 80)

[reflect,simul] = callReflectivity(bulkIns(i),bulkOuts(i),simLimits{i},repeatLayers{i},shiftedDat,layerSld,outSsubs(i),resolutionParams(i),controls.parallel,reflectivityType,useImaginary);

where outSsubs(i) is used as an input. However, this array has been initialised as a set of zeros with nothing else assigned to it at any point in the routine. On the other hand, in the domains version of the routines, we use allRoughs(i) for this argument, which in both cases is an output of processCustomFunction. It makes more sense to me that this is what should be used.

Could you please let me know which of these is the correct call @arwelHughes

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions