Skip to content

Potential bug in domains standard layers #216

Description

@DrPaulSharp

In targetFunctions\+domainsTF\+standardLayers for each of the single and parallel versions we define (lines 19-20):

% Additionally extract the additional domain layers details
domainContrastLayers = problemCells{19};

Then within the loop over contrasts, we have (lines 116-117):

        thisContrastLayers1 = allocateLayersForContrast(domainContrastLayers{1},outParameterisedLayers,useImaginary);
        thisContrastLayers2 = allocateLayersForContrast(domainContrastLayers{2},outParameterisedLayers,useImaginary);

Shouldn't this be domainContrastLayers{i,1} and domainContrastLayers{i,2} where i is the loop index? This makes more sense given the structure of the input array and the non-polarised version.

Let me know @arwelHughes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions