Repository navigation
fix(cli): convert custom calibration directories to Path - #1
Merged
839390315 merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both SO101 CLI entrypoints pass a non-empty
--calibration-dirdirectly from argparse (a string) intoSO101FollowerConfig. The config'sPath | Noneannotation does not coerce it.SOFollower.__init__then callsRobot.__init__, which executes:As a result, supplying a custom calibration directory raises
AttributeError: 'str' object has no attribute 'mkdir'before robot connection. The inference entrypoint reaches this after policy initialization.Convert the value to
Pathat both configuration boundaries. This makes custom calibration directories usable for calibration and inference. Both files already importPath. Keeping the existing conditional preserves omitted arguments and the explicit empty-string fallback; relative paths retain their existing interpretation.Validation
On macOS arm64, an isolated harness runs both complete CLI modules with the repository's actual config classes,
SOFollower/Robotconstructors,MotorCalibration, and calibration-file load/save methods. Python 3.10.20 and 3.12.13 withdraccus==0.8.0each verify 28 scenarios:mkdirAttributeErrormkdirAttributeError masks the actual problemCoverage includes relative and absolute paths, spaces, Unicode, existing directories, existing calibration reads without modifying their bytes during initialization, save/reload roundtrips, and custom robot IDs. Compilation and
git diff --checkpass.Hardware methods/factories and model/tensor dependencies are stand-ins; the runtime policy loader is replaced and its control loop uses zero steps. This validates path and calibration-file handling; real robot calibration, M50 execution and model performance were not tested.
Reproduction harness, commands and before/after reports: isolated verification bundle.