Repository navigation
new collective development for JAX/XLA - #657
Open
i-chaochen wants to merge 1 commit into
Open
i-chaochen wants to merge 1 commit into
i-chaochen wants to merge 1 commit into
Conversation
Introduce a header-only CollectivesFacade backed by a symmetric CCO heap and SDMA device communication. Add single-node implementations of reduce-scatter, all-reduce, all-gather, all-to-all, and collective-permute for gfx942, gfx950, and gfx1250. Reduce-scatter supports runtime-selectable SDMA push and direct-load pull modes. Add a runtime-configurable multi-GPU benchmark with correctness checks, along with the SDMA ADD32 completion support required by the new path. The default reduction dispatch instantiates f32/sum only. Co-authored-by: Pavel Emeliyanenko <pavel.emeliyanenko@amd.com>
i-chaochen
force-pushed
the
pavel/xla-mori-kernels-backup
branch
from
September 10, 2026 14:08
03c43bc to
1f3c1ac
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the initial work: https://github.com/ROCm/mori/tree/pemeliya/collectives-develop
Summary
Add a header-only, CCO-backed collective implementation intended for
XLA integration. The new path uses CCO symmetric windows and SDMA
copy-plus-completion packets for intra-node GPU communication without
depending on MORI's SHMEM collective path.
This PR provides the MORI-side facade and kernels; it does not yet add
JAX/XLA registration or Bazel integration.
Changes
CollectivesFacadefor symmetric allocation, lifecycle management,kernel dispatch, and runtime tuning.
and runtime selection of collective, size, algorithm, and slice count.
Current scope
f32withsum.ccoBarrierAll.Validation
The benchmark validates each rank's output after timing.
Before submission, record:
Performance
Any RCCL comparison should be rerun on the same hardware and software
configuration using the same bandwidth definition. No performance claim
is made from the preliminary checked-in timing log.