Skip to content

Make Nimble compile for watchOS. #954

Description

@danielsaidi
  • I have read CONTRIBUTING and have done my best to follow them.

Nimble doesn't compile for watchOS, since throwAssertion uses an exception type that isn't available for watchOS. This has been a problem for a long time and makes it hard to use Quick and Nimble in projects and packages that target watchOS.

While a real solution may be larger undertaking (one such PR already exists), I have created a pull request that disables the part that doesn't compile. Since only throwAssertion is affected, it's a very small tweak to a single place in the library.

With this tweak, developers will get a descriptive message and have the choice to either just not unit test on watchOS or to disable tests that rely on throwAssertion. This will at least make the code compile, which will be a huge improvement.

Activity

  1. danielsaidi commented on Jan 18, 2022

    @danielsaidi
    ContributorAuthor

    @ikesyo Any progress on this? I'd love to get my PR merged and released, so that I don't have to use my own forks in my various watchOS supporting projects. Lmk if I can help in any way.

  2. added this to the v10 milestone on Apr 15, 2022
  3. younata commented on Apr 15, 2022

    @younata
    Member

    Hey @danielsaidi, I merged your linked PR. I'd like to see CI building/running on watchOS, as well as the watchOS targets added to the xcodeproj before we actually release watchOS support. If you're able to, I'd love to see a PR for those.

    I'll leave this open as we don't yet have watchOS support.

  4. danielsaidi commented on Apr 15, 2022

    @danielsaidi
    ContributorAuthor

    That's great - thank you! I'd love to take a look at it if I get some time on my hands. If so, I'll write more here. 👍

  5. modified the milestones: v10.0.0, v11.0.0 on Apr 19, 2022
  6. younata commented on Apr 19, 2022

    @younata
    Member

    In the interest of getting v10 out the door sooner, I'm going to move watchOS support to the next major release.

  7. younata commented on Oct 21, 2022

    @younata
    Member

    This was done a few months ago, but forgot to close this. Closing it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions