Repository navigation
Visualize and restore LGND AOI searches on the map #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,9 @@ export function GoogleMapComponent() { | |
| }, [mapData.drawnFeatures]); | ||
|
|
||
| const cameraOptions = useMemo(() => { | ||
| if (mapData.targetPosition) { | ||
| return { center: mapData.targetPosition, range: 1000, tilt: 60, heading: 0 }; | ||
| } | ||
|
Comment on lines
+55
to
+57
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: sed -n '1,120p' components/map/google-map.tsx
sed -n '1,135p' components/map/map-3d.tsx
sed -n '1,90p' components/map/map-data-context.tsxRepository: QueueLab/QCX Length of output: 8755 🏁 Script executed: printf '%s\\n' '--- PR diff ---'
git diff 6b82b8f7b0b2c5a55077aa63fc1e2a97a6d844ac bfd0f9464f171a3b3bfe8ad358165a9a96ab4f96 -- components/map/google-map.tsx
printf '%s\\n' '--- state references ---'
rg -n -C 3 'targetPosition|cameraState' --glob '*.{ts,tsx}'
printf '%s\\n' '--- map component lifecycle references ---'
rg -n -C 3 'GoogleMapComponent|MapDataProvider|<Map3D|mapProvider|setMapData' --glob '*.{ts,tsx}' components app libRepository: QueueLab/QCX Length of output: 42224 🏁 Script executed: printf '%s\n' '--- chat provider, persistence, and map visibility ---'
sed -n '130,170p' components/chat.tsx
sed -n '205,310p' components/chat.tsx
printf '%s\n' '--- drawing-context read/write ---'
sed -n '250,320p' lib/actions/chat.ts
rg -n -C 3 'drawingContext|updateDrawingContext|cameraState' app components lib --glob '*.{ts,tsx}'
printf '%s\n' '--- map provider ---'
cat -n components/map/map-provider.tsx
printf '%s\n' '--- query handler ---'
cat -n components/map/map-query-handler.tsx
printf '%s\n' '--- navigation target handlers ---'
sed -n '75,130p' components/calendar-notepad.tsx
sed -n '85,130p' components/location-embeddings-section.tsx
sed -n '35,80p' components/map/map-3d.tsxRepository: QueueLab/QCX Length of output: 27681 🏁 Script executed: rg -n 'useMap3DCameraEvents|gmp-.*change|camera.*change' lib components/map --glob '*.{ts,tsx}'
printf '%s\n' '--- camera event hook ---'
fd 'map-3d-camera-events' lib components
cat -n lib/hooks/use-map-3d-camera-events.ts
printf '%s\n' '--- deep-compare effect ---'
cat -n lib/hooks/use-deep-compare-effect.ts
printf '%s\n' '--- MapDataProvider ---'
cat -n components/map/map-data-context.tsxRepository: QueueLab/QCX Length of output: 5085 Consume
Keep the target-first precedence for initial navigation, but consume 🤖 Prompt for AI Agents |
||
| if (mapData.cameraState) { | ||
| const { center, zoom, pitch, bearing } = mapData.cameraState; | ||
| // Convert Mapbox zoom to Google Maps range (approximate) | ||
|
|
@@ -63,9 +66,6 @@ export function GoogleMapComponent() { | |
| heading: bearing || 0, | ||
| }; | ||
| } | ||
| if (mapData.targetPosition) { | ||
| return { center: mapData.targetPosition, range: 1000, tilt: 60, heading: 0 }; | ||
| } | ||
| return { center: { lat: 37.7749, lng: -122.4194 }, range: 1000, tilt: 60, heading: 0 }; | ||
| }, [mapData.cameraState, mapData.targetPosition]); | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.