Repository navigation
ux(sql-workspace): the run controls move into the query tab strip (#1558) - #1752
Merged
Merged
Conversation
…e control row above the editor (#1558) The toolbar was its own 50 px row under the tab strip. It now sits right of the tabs (tabs keep at least 180 px, the controls get the rest and give up their labels as before). Diagram tabs show only the Diagram button.
github-actions
Bot
added
epic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1558, stage 2 (first of three PRs).
The run toolbar was its own 50 px row under the query tab strip. It now sits right of the tabs, in the same 40 px strip:
SqlQueryTabBartakes anactionsslot; the tabs keep at least 180 px, the actions get the rest and measure their labels against it (SqlWorkspaceToolbar.labelsWidth640,iconOnlyWidth420, now of the room the strip leaves).Checked in the running app (Linux, 1028 px, dark, SQLite demo): one strip with tabs left and Execute / Explain / History / Format / Open / Save / Session / Diagram right.
Not in this PR: staged-changes row into the result bar, auto-fit editor height, overflow menu below ~700 px (the controls still scroll horizontally there).