Repository navigation
refactor(database): one SshTunnelHost mixin instead of four copies of the tunnel code (#1508) - #1716
Merged
Merged
Conversation
github-actions
Bot
added
core
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1508
PostgresConnection,MysqlConnection,MongoConnectionandRedisConnectioneach carried the same fields, the secrets lookup, theopenTunnelcall and the release indisconnect/forceClose/ the connect error path.SshTunnelHost(core/database/ssh_tunnel_host.dart) now holds the handle and the steps:openSshTunnel(reads the stored secrets when none were passed, null when the tunnel is off),adoptSshTunnel,forgetSshTunnel(MySQL's superseded connect attempt) andreleaseSshTunnel(optional log label). No behaviour change: the release sites still log under the same labels, MySQL still checks its connect generation between opening and adopting, MongoDB still tunnels to the first seed host.About 150 lines fewer. Test: no tunnel without a config or when disabled; releasing with none open is harmless.