Repository navigation
fix(settings): log why PreferencesDialog could not load the preferences (#1637) - #1695
Merged
Merged
Conversation
github-actions
Bot
added
bug
… through widgets.dart)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1637.
PreferencesDialog._loadread the settings one after another insidetry { ... } catch (_) {}. A failing read (corrupt settings database, I/O error, schema mismatch) left the dialog on its defaults and no trace anywhere. It now catches(error, stackTrace)and writes both withdebugPrint; behaviour for the user is unchanged (the dialog still opens with its defaults).No test: the failure has to come from
AppSettings/ the local database, which the dialog tests do not let me break without a larger seam than this change is worth.