Skip to content

ui(grid): fix RenderFlex overflow during DataGridCalcBar collapse animation (#1641) - #1674

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1641-datagrid-calcbar-overflow
Oct 17, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1641-datagrid-calcbar-overflow

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1641

  • Replaced AnimatedContainer with QueryaAnimatedExpand in DataGridCalcBar to avoid squeezing child Row below its intrinsic minimum height during collapse
  • Applied QueryaTypography.mono and QueryaTypography.monoFontFamilyFallback to _StatBadge values
  • Added unit and widget tests in test/features/workspace/data_grid_calc_bar_test.dart verifying stats rendering, monospace typography, clipboard copy, and overflow-free animation during collapse

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 0e44d61 into dev Oct 17, 2026
12 of 13 checks passed
@github-actions github-actions Bot added bug Something isn't working frontend Theme parser epic label: frontend labels Oct 17, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1641-datagrid-calcbar-overflow branch October 17, 2026 04:31
ZhuchkaTriplesix added a commit that referenced this pull request Oct 17, 2026
#1674 collapses DataGridCalcBar with QueryaAnimatedExpand, which does
not build the content while collapsed. The test selected one text cell,
for which the bar is hidden by design, and found 'Count: ' only because
the old zero-height container still built it. It now selects a numeric
cell, and a second test pins that a single text cell keeps the bar
collapsed. dev has been red on this since #1674.
ZhuchkaTriplesix added a commit that referenced this pull request Oct 17, 2026
…v red) (#1675)

* docs(changelog): entries for the fixes and speed-ups merged on 2026-10-17

Redis sockets per database (#1569), macOS update and unsigned build
(#1587, #1592), Format SQL backslashes (#1566), MongoDB parsing and
Extended JSON (#1513, #1539, #1667), ERD / MCP catalog (#1572), README
(#1500), and the grid / results / export speed-ups (#1520, #1533,
#1537, #1548). The PRs left CHANGELOG.md alone so they would not
conflict with each other.

* test(workspace): the calc bar test selects a cell the bar is shown for

#1674 collapses DataGridCalcBar with QueryaAnimatedExpand, which does
not build the content while collapsed. The test selected one text cell,
for which the bar is hidden by design, and found 'Count: ' only because
the old zero-height container still built it. It now selects a numeric
cell, and a second test pins that a single text cell keeps the bar
collapsed. dev has been red on this since #1674.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend Theme parser epic label: frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant