Repository navigation
ui(grid): fix RenderFlex overflow during DataGridCalcBar collapse animation (#1641) - #1674
Merged
Merged
Conversation
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Oct 17, 2026
#1674 collapses DataGridCalcBar with QueryaAnimatedExpand, which does not build the content while collapsed. The test selected one text cell, for which the bar is hidden by design, and found 'Count: ' only because the old zero-height container still built it. It now selects a numeric cell, and a second test pins that a single text cell keeps the bar collapsed. dev has been red on this since #1674.
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Oct 17, 2026
…v red) (#1675) * docs(changelog): entries for the fixes and speed-ups merged on 2026-10-17 Redis sockets per database (#1569), macOS update and unsigned build (#1587, #1592), Format SQL backslashes (#1566), MongoDB parsing and Extended JSON (#1513, #1539, #1667), ERD / MCP catalog (#1572), README (#1500), and the grid / results / export speed-ups (#1520, #1533, #1537, #1548). The PRs left CHANGELOG.md alone so they would not conflict with each other. * test(workspace): the calc bar test selects a cell the bar is shown for #1674 collapses DataGridCalcBar with QueryaAnimatedExpand, which does not build the content while collapsed. The test selected one text cell, for which the bar is hidden by design, and found 'Count: ' only because the old zero-height container still built it. It now selects a numeric cell, and a second test pins that a single text cell keeps the bar collapsed. dev has been red on this since #1674.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1641
AnimatedContainerwithQueryaAnimatedExpandinDataGridCalcBarto avoid squeezing child Row below its intrinsic minimum height during collapseQueryaTypography.monoandQueryaTypography.monoFontFamilyFallbackto_StatBadgevaluestest/features/workspace/data_grid_calc_bar_test.dartverifying stats rendering, monospace typography, clipboard copy, and overflow-free animation during collapse