You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(extensions): Table Browser must require PK and not discard dirty edits #869
Extension Table Browser is fail-open vs native Table Browser after #771 / #772 / #773.
Staging attaches whenever supportsMutations is true — no PK / schema loaded check.
ExtensionDriverSession.getTableSchema catches errors and returns an emptyTableSchemaMeta. Save then builds UPDATE/DELETE WHERE from every column.
Refresh, pagination, filter, and table switch dispose() the staging buffer with no confirm. No UnsavedWorkRegistry.
Success toast uses affectedRows ?? mutations.length — a driver that omits or zeroes affectedRows still looks like a full success. No expectDmlMatchedRows.
Repro
Open an extension table with mutations enabled, edit a cell, change page / Refresh → edits gone.
Driver without PK or with a failing db.getTableSchema → cells still editable; Save can update multiple rows.
Scope
Disable staging without a real PK; treat schema load failure as unavailable (not empty PK).
Activity
ZhuchkaTriplesix commentedon Sep 27, 2026
Resolved by #935 (already merged into
dev; not auto-closed since this repo's default branch ismainand PRs merge intodev).