chore(ui): remove the remaining shadcn buttons and add guard tests for the button standard #1339
Copy link
Copy link
Closed
Labels
P3Low priority / Polish & EnhancementsLow priority / Polish & EnhancementsenhancementNew feature or requestNew feature or requestfrontendTheme parser epic label: frontendTheme parser epic label: frontendtestsTheme parser epicTheme parser epicuiUser interface components and widgetsUser interface components and widgets
Description
Part of #1331. Last, after the two migration issues.
Scope
- Delete the deprecated
QueryaActionButtonwrapper and theQueryaIconButtonDensityaliases. - Guards in
test/guards/(same style asno_raw_material_dialogs_test.dart):no_shadcn_buttons_test.dart:PrimaryButton,OutlineButton,GhostButton,DestructiveButton,SecondaryButton,LinkButton,ButtonSize,ButtonDensityandButtonStyle.*ofshadcn_flutterare forbidden outside an explicit allow-list (for third-party code that is replaced later).no_raw_material_buttons_test.dart:IconButton,TextButton,ElevatedButton,OutlinedButton,FilledButtonforbidden; extends the existing results-only guard to the whole app.no_ad_hoc_button_classes_test.dart: a class named*Buttonoutsidelib/shared/widgets/, and a button-likeInkWell/GestureDetector(aTextorIconchild withonTap) outside the kit, fail.button_literals_test.dart: nowaitDuration: Duration(...)literal, noBorderRadius.circular(n)on a kit control.
- Update
docs/ui-kit.md's guard table and the Obsidian note.
Acceptance
- The guards pass on
dev; the allow-list is empty or each entry names a follow-up issue. -
grep -r "shadcn_flutter" lib | grep -i buttonis empty.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3Low priority / Polish & EnhancementsLow priority / Polish & EnhancementsenhancementNew feature or requestNew feature or requestfrontendTheme parser epic label: frontendTheme parser epic label: frontendtestsTheme parser epicTheme parser epicuiUser interface components and widgetsUser interface components and widgets
Activity
refactor(ui): raw Material buttons and literal tooltip delays leave l…
refactor(ui): private and raw Material buttons leave lib, button guar…
ZhuchkaTriplesix commentedon Oct 25, 2026
Done on dev in #1403, #1427, #1476 (merged). Closing by hand: the PRs target dev, so GitHub would only close this when dev is merged into main.