Skip to content

Add subsquid host metrics - #54

Merged
dewabisma merged 2 commits into
mainfrom
beast/add-hm-for-subsquid
Sep 11, 2026
Merged

Add subsquid host metrics#54
dewabisma merged 2 commits into
mainfrom
beast/add-hm-for-subsquid

Conversation

@dewabisma

Copy link
Copy Markdown
Contributor

Previously we only get the processor metric now we also add the host metric

@dewabisma
dewabisma requested a review from n13 September 11, 2026 00:40

@n13 n13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: REQUEST_CHANGES — the new host scrape is wired into the selector and metric panels, but the proc-1 status tile still monitors the old processor scrape.

  • [P1] Point the proc-1 host-status tile at the new host-metrics job (grafana/dashboards/infrastructure/subsquid-host.json:36). The PR maps proc-1 to ${fleet}-subsquid-proc-1-hm for the node-exporter panels, while this tile continues to query ${fleet}-subsquid-proc-1, which is the processor metrics endpoint. If node_exporter or its route fails while the processor endpoint remains available, the Subsquid Host dashboard reports proc-1 as UP even though all of its host metrics are unavailable. Change this query to ${fleet}-subsquid-proc-1-hm, or expose processor and host-exporter health as distinct tiles if both signals are intentional.

Validation: reviewed the complete diff from 14e0d019c33acaa4ba11b39626115e774e815bb2 to 98e250621416e684ee68b4ac37b848927b926aa4; Prometheus 3.14.0 promtool check config passed; YAML parsing confirmed 36 unique scrape jobs and both new host jobs; dashboard JSON parsing, targeted Prettier, and git diff --check passed. Both new DNS names resolve and return the expected unauthenticated HTTP 401 from Cloudflare Access. The repository-wide formatting check remains limited by three unchanged files.

@dewabisma
dewabisma requested a review from n13 September 11, 2026 05:59

@n13 n13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: APPROVE — the new Subsquid processor-host node_exporter scrape is correctly wired into Prometheus and the host dashboard, including the prior status-tile fix.

No blocking findings. Processor application metrics remain on ${fleet}-subsquid-proc-1, while host metrics and the proc-1 selector/status tile consistently use ${fleet}-subsquid-proc-1-hm for both Planck and mainnet.

Validation:

  • Reviewed the complete diff from 14e0d019c33acaa4ba11b39626115e774e815bb2 to f24607ccbc14e86b87d86988938c6ee5a3607878 and the follow-up fix commit.
  • Prometheus 3.14.0 promtool check config passed using a SHA-256-verified official release binary.
  • Dashboard JSON parsing, semantic YAML checks (36 unique jobs and both expected targets/Cloudflare headers), targeted Prettier, and git diff --check passed.
  • Both new hostnames resolve and return the expected unauthenticated HTTP 401 from Cloudflare Access.
  • No GitHub checks are configured for this PR.

@dewabisma
dewabisma merged commit 3fa76db into main Sep 11, 2026
@dewabisma
dewabisma deleted the beast/add-hm-for-subsquid branch September 11, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants