Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe Open With action now dismisses the QuickLook preview after invoking the system dialog, closing pinned windows directly and delegating unpinned previews to ViewWindowManager; the file header’s BOM was also removed. Sequence diagram for dismissing the preview after Open WithsequenceDiagram
participant User
participant ViewerWindow
participant ShareHelper
participant ViewWindowManager
participant SystemDialog
User->>ViewerWindow: buttonOpenWith.Click
ViewerWindow->>ShareHelper: Share(_path, this, true)
ShareHelper->>SystemDialog: OpenAs_RunDLL
alt Pinned
ViewerWindow->>ViewerWindow: Close()
else Unpinned
ViewerWindow->>ViewWindowManager: GetInstance()
ViewWindowManager->>ViewWindowManager: ClosePreview()
end
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Brief Description of Changes
ViewerWindow.xaml.cs, clicking the "Open With" button (buttonOpenWith) previously launchedShareHelper.Share(_path, this, true)(invokingrundll32.exe shell32.dll,OpenAs_RunDLL) but left the QuickLook preview window open on screen.buttonOpenWith.Clickto dismiss the preview window (Close()if pinned, orViewWindowManager.GetInstance().ClosePreview()), matching the closing behavior of the default "Open with [App]" button (buttonOpen).Related Issue (if any)
Fixes #1267
Additional Notes
Tested opening various file types via the Open With dialog. The QuickLook window cleanly closes upon invoking the system dialog.
Summary by Sourcery
Bug Fixes: