Skip to content

Add keyboard navigation shortcuts and click to pause in VideoViewer (#47, #1979, #1753) #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BerryUIKI wants to merge 1 commit into
base: master
Choose a base branch
from
+58 −2
Open

Add keyboard navigation shortcuts and click to pause in VideoViewer (#47, #1979, #1753) #2002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 58 additions & 2 deletions QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ViewerPanel.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright © 2017-2026 QL-Win Contributors
// Copyright © 2017-2026 QL-Win Contributors
//
// This file is part of QuickLook program.
//
Expand Down Expand Up @@ -109,6 +109,10 @@ public ViewerPanel(ContextObject context)
};

PreviewMouseWheel += (_, e) => ChangeVolume(e.Delta / 120d * 0.04d);

Focusable = true;
Loaded += (_, _) => Focus();
PreviewKeyDown += ViewerPanel_PreviewKeyDown;
}

private partial void LoadAndInsertGlassLayer();
Expand Down Expand Up @@ -200,17 +204,69 @@ public void Dispose()

private void Panel_MouseLeftButtonDown(object sender, MouseButtonEventArgs e)
{
Focus();

if (e.LeftButton == MouseButtonState.Pressed)
{
var wnd = Window.GetWindow(this);
// Do not allow dragging when window is borderless (e.g. fullscreen)
if (wnd?.WindowStyle == WindowStyle.None)
{
TogglePlayPause(this, EventArgs.Empty);
return;
}

if (wnd != null)
{
var startLeft = wnd.Left;
var startTop = wnd.Top;

wnd.DragMove();

// If the window was not moved, treat this interaction as a click to toggle play/pause
if (Math.Abs(wnd.Left - startLeft) < 2 && Math.Abs(wnd.Top - startTop) < 2)
{
TogglePlayPause(this, EventArgs.Empty);
}
Comment on lines +227 to +230

@sourcery-ai sourcery-ai Bot Sep 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (bug_risk): A drag that moves the window away from its starting point and then back within two pixels is treated as a click, so the video is paused or resumed even though the user performed a drag.

Triggers: When the user drags the preview window back to approximately its original position.

Suggested fix: Track whether the pointer moved beyond the drag threshold during the interaction, rather than comparing only the final window position with the starting position.

}
}
}

private void ViewerPanel_PreviewKeyDown(object sender, KeyEventArgs e)
{
switch (e.Key)
{
case Key.Left:
Seek(-TimeSpan.FromSeconds(5).Ticks);
e.Handled = true;
break;

case Key.Right:
Seek(TimeSpan.FromSeconds(5).Ticks);
e.Handled = true;
break;

case Key.Up:
ChangeVolume(0.05d);
e.Handled = true;
break;

wnd?.DragMove();
case Key.Down:
ChangeVolume(-0.05d);
e.Handled = true;
break;
}
}

private void Seek(long deltaTicks)
{
if (mediaElement == null)
return;

var target = Math.Max(0, Math.Min(mediaElement.MediaDuration, mediaElement.MediaPosition + deltaTicks));
mediaElement.MediaPosition = target;
}

public event PropertyChangedEventHandler PropertyChanged;

private void MediaOpened(object o, RoutedEventArgs args)
Expand Down