Repository navigation
(feat) build cli apps with pynest - #73
Merged
ItayTheDar merged 15 commits intoAug 6, 2024
Merged
Conversation
add echo as an extra param to allow disabling logs from db
ItayTheDar
self-requested a review
July 28, 2024 15:11
ItayTheDar
approved these changes
Aug 6, 2024
| from functools import lru_cache | ||
|
|
||
|
|
||
| @lru_cache() |
Contributor
There was a problem hiding this comment.
This is not up to date, need to change to the Injectable decorator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary and Walkthrough for PyNest
Overview
This pull request (PR) includes several updates across various components of the PyNest project. The primary focus is on refactoring, enhancements, and expanding functionality. Key changes include updating CLI commands, restructuring modules and services, and improving documentation.
Key Changes
CLI Command Refactoring
create-nest-appcommand has been replaced withgenerate application, streamlining the command structure and making it more intuitive.g modulecommand has been updated togenerate resource, which now includes options for generating controllers, services, and modules more cohesively.Documentation Updates
docs/async_orm.mdand other related documents have been updated to reflect the latest changes in syntax and best practices.Workflow Modifications
cli_test.yamlandintegration_test.yaml) have been updated to align with the new CLI command structure. This ensures that CI processes accurately reflect the latest application generation and testing methodologies.Module and Service Enhancements
examples/CommandLineAppdirectory, illustrating the use of CLI commands within a modular structure. This includesAppController,AppService, and related files, providing a comprehensive example of setting up and using the CLI within an application context.Version Bump
0.2.3to0.2.4, reflecting the incremental improvements and updates included in this PR.Detailed Walkthrough
CLI Command Changes
create-nest-appcommand withgenerate application, making it more descriptive and aligned with the command's function. The command now includes options for specifying the app name, database type, and async configuration.Documentation Improvements
docs/controllers.mdhas been extensively rewritten to include a detailed explanation of controller creation, routing, and HTTP methods. It now provides step-by-step guides and examples to illustrate these concepts clearly.mkdocs.ymlfile reorganize the documentation structure, making it easier to navigate and find relevant information.New Example Files
examples/CommandLineAppdirectory demonstrates the practical application of CLI commands. These examples serve as a reference for setting up CLI applications, including controller and service layers.Workflow Updates
.github/workflows/cli_test.yamland.github/workflows/integration_test.yamlfiles ensure that the CI/CD pipelines are consistent with the new command structure, preventing potential build and deployment issues.Conclusion
This PR represents a significant step forward in the PyNest project's development, enhancing usability, consistency, and documentation. The changes improve both the developer experience and the overall functionality of the CLI and associated tools. Reviewers are encouraged to test the new commands and review the updated documentation to ensure clarity and correctness.