fix: preserve immutable Q10 points in model conformance checks - #965
Merged
allenporter merged 1 commit intoSep 17, 2026
Merged
Conversation
This was referenced Sep 17, 2026
allenporter
approved these changes
Sep 17, 2026
allenporter
left a comment
allenporter
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model conformance check fails on
mainfor the existing frozenQ10RoborockPoint. A frozen dataclass cannot inherit from the non-frozenRoborockBase, so enforcing that inheritance would require changing the coordinate value's public behavior.Document and check an explicit exception for this one existing type. All other domain models retain the inheritance requirement. Add regression tests for rejected coordinate assignment/deletion, equality, and stable hashing; production code is unchanged.
Fixes #964.
Validation: reproduced the failure on untouched
eac001c(1 failed, 83 passed); with this change, the full suite reports 1320 passed, 53 existing xfailed, with 92 snapshots passed. All pre-commit checks and wheel/sdist builds pass.