Conversation
metadata_encoding and metadata_errors made the caller pick one encoding
for a whole container, which cannot represent a file that mixes them
across tags. FFmpeg stores tags as bytes with no declared encoding, so
decode them the way Python decodes filesystem paths. Valid UTF-8 will
read normally, while anything else survives as surrogates and encodes
back unchanged. A tag in another encoding can be recovered per key with:
value.encode("utf-8", "surrogateescape").decode("cp1251")
Drops both fields, making a container 16 bytes smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadata_encoding and metadata_errors made the caller pick one encoding for a whole container, which cannot represent a file that mixes them across tags. FFmpeg stores tags as bytes with no declared encoding, so decode them the way Python decodes filesystem paths. Valid UTF-8 will read normally, while anything else survives as surrogates and encodes back unchanged. A tag in another encoding can be recovered per key with:
Drops both fields, making a container 16 bytes smaller.