Conversation
Delete `avrational_to_fraction()`, the last thing in PyAV producing a Fraction, and route its call sites through from_avrational. Rational attributes now hand back an AVRational, never None. An unset value is the falsy `AVRational(0, 1)` Settable attributes are stubbed as property/setter pairs so a `fractions.Fraction` is still accepted on assignment, as documented, while reads are typed AVRational. The reflected arithmetic dunders gain overloads, without which `ctx.framerate = 1 / ctx.time_base` fails to type check on the float arm of their return union.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
avrational_to_fraction(), the last thing in PyAV producing a Fraction, and route its call sites through from_avrational. Rational attributes now hand back an AVRational, never None. An unset value is the falsyAVRational(0, 1)Settable attributes are stubbed as property/setter pairs so a
fractions.Fractionis still accepted on assignment, as documented, while reads are typed AVRational. The reflected arithmetic dunders gain overloads, without whichctx.framerate = 1 / ctx.time_basefails to type check on the float arm of their return union.