Repository navigation
Conversation
ste26054
marked this pull request as ready for review
October 9, 2026 08:58
|
Automatic reviews are disabled for this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/🧐 Analytics/server-events/server-events-attributes.md, thechannelattribute:in_appnow excludes Subscribe with Google. Thechannelkey is absent for Subscribe with Google purchases, which carryis_swg: true.in_appdefinition is split into short sentences.Why
Purchasely/Purchasely-Backend#5011 gives Subscribe with Google subscriptions no channel. The user buys them on the publisher's website through Google, without the app. So they are neither
in_appnorapp2web(started in the app, paid on the web). Webhooks sentin_appfor them before.How to verify
channelrow of the page. It matchesPurchaseChannel.forin Purchasely/Purchasely-Backend#5011.Notes
mobile_application_idbackfill on subscriptions to finish.gpt-6-astra(Herdr reviewer) reviewedorigin/v6.0..16107718with the backend change. Fixed: thein_appdefinition had 24 words.Greptile
Skipped: Markdown docs only (one table cell)