What happened
When sketch overrides are absent, the planner silently supplies hardcoded CMS, KLL, HLL, and HydraKLL parameters. Invalid top-k values are also parsed as floating-point values and cast to integers.
What I expected
The planner should either receive explicit sketch parameters or an explicitly selected named profile. Accidental omission, invalid dimensions, fractional top-k values, and out-of-range parameters should fail plan generation.
Steps to reproduce
- Generate a plan for an approximate aggregation without sketch overrides.
- Compare the emitted sketch parameters with a plan using explicit overrides.
- Supply an invalid or fractional top-k value and regenerate the plan.
- Observe that planning succeeds with implicit or coerced values.
Additional context
Defaults affect approximation error, memory usage, and runtime cost. Validate parameters at the planner boundary and include the resolved profile or parameters in plan diagnostics.
Concrete examples
A plan for an approximate aggregation is generated without sketch overrides:
requested aggregation: HLL
sketch overrides: absent
emitted precision: default value 14
If the omission was accidental, the plan still succeeds with a different accuracy and memory profile.
A malformed top-k value such as 2.7 should also be rejected. It should not be silently converted to an integer. The expected behavior is either an explicitly selected sketch profile or a plan-generation error.
What happened
When sketch overrides are absent, the planner silently supplies hardcoded CMS, KLL, HLL, and HydraKLL parameters. Invalid top-k values are also parsed as floating-point values and cast to integers.
What I expected
The planner should either receive explicit sketch parameters or an explicitly selected named profile. Accidental omission, invalid dimensions, fractional top-k values, and out-of-range parameters should fail plan generation.
Steps to reproduce
Additional context
Defaults affect approximation error, memory usage, and runtime cost. Validate parameters at the planner boundary and include the resolved profile or parameters in plan diagnostics.
Concrete examples
A plan for an approximate aggregation is generated without sketch overrides:
requested aggregation: HLL
sketch overrides: absent
emitted precision: default value 14
If the omission was accidental, the plan still succeeds with a different accuracy and memory profile.
A malformed top-k value such as 2.7 should also be rejected. It should not be silently converted to an integer. The expected behavior is either an explicitly selected sketch profile or a plan-generation error.