fix(precompute_engine): register GorillaQueryEngine from ASAP_GORILLA_S3_* env - #88
Merged
Merged
Conversation
…_S3_* env The deployed backend Docker image uses the `precompute_engine` binary (see ASAPCollector/deploy/docker/Dockerfile.backend), but the GorillaQueryEngine env-var registration block from PR #87 only landed in `src/main.rs`. As a result, deployments that set `ASAP_GORILLA_S3_*` env vars never got a `GorillaQueryEngine` plugged into the EngineRouter, and cold-archive queries fell back silently without a `data_source: gorilla_archive` marker on the response. This mirrors the registration block from `src/main.rs` into `src/bin/precompute_engine.rs` so the deployed image actually wires the cold-archive engine when the env vars are present (and remains silent / warn-only when they're absent). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
precompute_enginebinary (seeASAPCollector/deploy/docker/Dockerfile.backend), but the GorillaQueryEngine env-var registration block from PR feat(http): wire EngineRouter into query handler — Gorilla-S3 archive routes via router (Phase 6 follow-up) #87 only landed insrc/main.rs. So deployments that setASAP_GORILLA_S3_*env vars never registered aGorillaQueryEngineon the EngineRouter, and cold-archive queries fell back silently without adata_source: gorilla_archivemarker.src/main.rsintosrc/bin/precompute_engine.rsso the deployed image actually wires the cold-archive engine.Test plan
cargo check --bin precompute_engine -p query_engine_rust— cleancargo build --release --bin precompute_engine -p query_engine_rust— cleanasap/query-backend:devimage and re-run ASAPCollector MVP demo (issue chore(tls): reqwest rustls-tls — drop libssl, make Dockerfile base-agnostic #46) — verifydata_source: gorilla_archivein cold-fallback ad-hoc query response.Companion PR: ASAPCollector
mvp/issue-46-rerun(run_mvp_demo.sh re-run + MVP_REPORT_v2.md).Refs ASAPCollector#46.
🤖 Generated with Claude Code