Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The backend persisted complete selected Planner DAGs under
PrecomputePlan.executable_dags, including query-only operators, and fetchedasap-precompute-rsfrom ASAPCollector to decode sketch state. The design in #737 separates maintenance from query execution and removes that build/runtime dependency.Before this PR
For
Input → BuildSummary → SummaryEstimate → Result, PrecomputePlan contained all four semantic nodes. The backend reconstructed DDSketch/KLL through a Collector wrapper and some tests required Collector's Rust crate.After this PR
asap_sketch_codeccrate decodes full and legacy bare sketchlib envelopes. Backend ingest and tests use sketchlib directly.asap-precompute-rsand the ASAPCollector Cargo patch are removed from the backend dependency graph.Verification
cargo test -p asap_types --locked --quiet: 108 passed.cargo test -p control_plane --locked --quiet: 438 passed across targets.cargo test -p data_plane --lib --locked --quiet: 1,182 passed; the new legacy-normalization test was rerun after its final change.cargo test -p data_plane --test edge_sketch_codec --locked -- --test-threads=1: 4 passed.cargo test -p data_plane --test asapquery_compatibility_process_e2e --locked -- --test-threads=1: 17 passed, 1 existing stale-evidence test ignored; a production process test was rerun after the normalization change.ASAP_E2E_CARGO_TARGET_DIR="$PWD/target" ./scripts/e2e.sh whole: passed controller publication → CollectorPlan exchange → OTLP ingest → PromQL serving and failed-rollout preservation.cargo tree -p data_plane --lockedcontains no ASAPCollector orasap-precompute-rs; formatting andgit diff --checkpass.Remaining migration work
This draft does not yet implement the SDS state-slot/instance contract and standalone catalog-materialization removal in #737. The version 1 reader remains for compatibility; retirement of the old execution path requires the remaining migration gates. One older ignored ERP/KLL process fixture still needs refreshed lifecycle evidence; the whole-backend process E2E is now active and passes.