Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708.
Physical alternatives use sets of materialization keys, so the 64-candidate limit is not a representation constraint. Remove that rejection and the 63-set enumeration cutoff, which omitted later leaves' singleton/complement choices. Keep the existing key-set representation and remove redundant deduplication for the distinct large-inventory choices.
Before this PR: 100 optional keys produced only 63 materialization candidates, and selection rejected any inventory with more than 64 alternatives, including a cheaper candidate at position 65.
After this PR: 100 keys produce 202 materialization candidates plus native execution, and the selector considers every supplied alternative. Search remains exhaustive through four keys; larger inventories use all/none plus every singleton/complement pair (
2 + 2N), with non-exhaustive coverage disclosed. Larger inventories require more compilation and pricing work; this does not claim a global optimum.Verification: Both regressions failed against the original behavior and passed after the fix. All 411 control-plane tests and 24 focused runtime tests passed. Coverage includes mask-to-binding consistency, absence of deployed raw scans, exact-leaf composition and fallback, materialized subDAG boundaries, shared dependencies, and binary operand ordering. No runtime routing changes were needed.