Remove unused interfaces and historical commentary (#703) - #711
Merged
Merged
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Address four cleanup items in #703: historical source commentary, redundant HTTP adapter traits, unused accumulator factories, and disconnected control-plane modules.
What
HttpProtocolAdapterand construct the default Prometheus adapter directly.summary_reconcileandthreshold_alloc, whose only callers were their own tests.How
Keep the existing adapter method implementations, VictoriaMetrics language identity, and live accumulator creation/merge paths. Remove unused definitions and exports after checking repository references. Four commits separate the cleanup areas.
Before this PR
HTTP dispatch used a single-arm factory and three traits always consumed together. Unused factories and self-tested modules expanded the public Rust surface. Comments described retired implementations and migrations as ongoing work.
After this PR
HTTP dispatch uses one adapter trait with direct construction. Developers work against the live interfaces and current contract documentation. Existing query parsing, responses, fallback, and accumulator behavior are preserved.
Evidence
Net removal: 2,644 lines across 96 files. Non-documentation Rust tokens are unchanged in all 79 comment-only files. Screenshots and performance measurements are not applicable.
Verification
e2e_controller_plans_and_backend_serves12 passed, covering controller configuration and backend sketch queries.cargo check --workspace --all-targets, formatting,git diff --check, and removed-symbol reference checks passed. Used Rust 1.98.0; disabled incremental compilation after a cache-file error during control-plane test compilation.Architectural decisions
Keep a single HTTP trait because request and response traits have no independent consumers. Retain separate Prometheus and VictoriaMetrics implementations for their language and fallback contracts.
Limitations and follow-up
Partially addresses #703; other cleanup items remain outside this PR. Removed public Rust symbols require downstream source migration if used outside this repository. The obsolete
lib.rsmapping table was already removed in #710.Human review — do not complete with an agent