feat(contract): declare producer partition watermark scope - #678
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion barriers need an installed producer/partition scope; Remote Write samples and observed timestamps do not establish that authority.
This adds optional
partition_idsto the existingProducerContractand aPrecomputePlan::validate_watermark_scopehelper using the existingSummaryWatermarkBarrier. Before, producer bindings named no authoritative partition roster. Now callers can check full catalog generation, plan envelope, materialization, producer and partition membership. Empty legacy rosters preserve the old serialized form and authorize no completion claims.Verification: the focused shared regression passed on clean dependency checkouts. It covers legacy wire equality, deterministic roster roundtrip, valid scope, missing roster, wrong producer/partition/materialization/catalog snapshot/version/envelope, malformed epoch/sequence and empty partition names. Independent bounded source review passed; no new wire DTO was introduced.
This does not add an HTTP barrier endpoint, producer authentication, durable progress or continuous scheduling. Runtime integration must still enforce those and protect new populations against writes behind a closed watermark. Full-plan validation is deliberate at this prerequisite layer; runtime may validate/cache installed contracts separately.