docs: sync TODO.md after persist + harness PRs - #67
Merged
Merged
Conversation
* §4 Serialization format versioning tests — mark done with #65 and document the three landed tests (schema / backfill / part_meta) including the no-data-corruption assertion. Adds a defense-in-depth follow-up note for a live-restart docker-compose variant. * §1 Cold-query fallback latency follow-up — point at #66 (benchmarks/run_full_eval.sh). The runner exists and can produce the ≤2× P99 number; only blocker now is the ASAP_COLD_STORE_ROOT CLI flag wiring in asap-query-engine main.rs (de-scoped per the paper review — flagged here so we don't lose the dependency chain). §2 (accuracy profile) and §5 (correctness proofs) intentionally untouched — those weren't in scope for this round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mod v2_forward_compat:schema_v1_with_future_version_falls_back_and_rewrites_cleanbackfill_v1_with_future_version_falls_back_and_rewrites_cleanpart_meta_with_future_version_returns_format_errorAll three pin the contract to
PERSIST_FORMAT_VERSION + 1so the tests self-update if/when the version is bumped, and the schema/backfill cases explicitly assert no data corruption (rewritten file at v_current with valid shape, no leakage from the bumped blob).benchmarks/run_full_eval.sh). The runner can produce the ≤2× P99 number; only remaining blocker is theASAP_COLD_STORE_ROOTCLI flag wiring inasap-query-engine'smain.rs(de-scoped per the paper review — flagged here so the dependency chain isn't lost).§2 (accuracy profile) and §5 (correctness proofs) intentionally untouched — those weren't in scope for this round.
Test plan
🤖 Generated with Claude Code