Acquire immutable maintenance input cohorts before publication - #662
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Multi-input maintenance must acquire every completed source before reserving output.
What
Add a private, deterministic acquisition path over the existing frozen-input type and route the current single-source consumer through it.
How
Validate the exact installed input-definition set, reject duplicate physical populations, sort inputs by definition/SID/group, read every durable window, and recheck the shared catalog generation. Failure returns no partial cohort and performs no publication.
Before this PR
The maintenance consumer acquired one source directly.
After this PR
The storage boundary can acquire multiple requested source populations as one read set. Existing execution capability gates remain in place.
Verification
Three actual-sketchlib-139 storage tests passed, covering two durable definitions, a missing second window, catalog transition, deterministic group ordering, duplicate/missing inputs, and existing restart/publication guards.
Limits
This is input acquisition only. All-source publication revalidation, complete population routing, multi-frontier execution, continuous watermarks, and sliding scheduling remain subsequent layers. No new wire DTO or broader execution claim.