Share validated source-window cohorts for derived maintenance - #661
Merged
zzylol merged 3 commits intoSep 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP compilation and installation duplicated the source-window checks for immutable derived state. This adds one shared validator returning borrowed existing materialization definitions, so both paths use the same window contract without a new serialized DTO.
The contract accepts matching explicit full stored windows, including full-window sliding, and rejects missing sliding origins, shifted windows, mismatched slides, duplicate sources, derived sources, and lossy pane layouts. Window selection remains Planner-owned. Existing installation/runtime limits remain in place until multi-source completion and execution are implemented.
Before: equivalent window checks were scattered across compiler and installation code. After: the shared cohort view can also support the next batch-input consumer while preserving explicit source identities and window parameters.
Validation: all 99 shared-types tests pass, including borrowed identity, multiple source definitions, and fingerprint changes for origin/slide/layout. Focused CP integration and the final explicit/legacy origin regression pass. Legacy nonoverlapping definitions retain their existing matching absent-origin behavior. No new runtime or performance claim.