refactor(clickhouse): remove unused relational tree executor - #652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL serving already executes the installed QueryPlan, but a second recursive SummaryNode executor and summary-state adapter remained solely for one mock test. Keeping both paths obscured which execution contract production uses.
Remove that unused executor, its adapter trait and state bridge. The chain test now exercises the production typed Filter, Project, Sort and Limit operations directly, including the filter that its name advertised. Compatibility module documentation describes the remaining summary API accurately.
Before this PR, SQL operator testing passed through a legacy tree executor that serving never called. After this PR, the test and serving use the same relational operator implementation; installed QueryPlan execution remains unchanged.
Verification: repository-wide reference search found no production caller of the removed path. All 26 ClickHouse query-engine unit tests pass against the actual sketchlib #139 checkout, including coverage and output assertions. Independent source review passed. Performance measurements and screenshots are not applicable.