fix(storage): publish manifest changes after durable writes - #645
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest failures must not expose uncommitted parts or make a successful part publication look retryable.
Serialize append and compaction through the existing mutation mutex. Write and sync the log before publishing the live change. Roll back failed writes to the original log length; if rollback cannot be made durable, reject further writes and compaction until reopen. Optional compaction failure no longer turns a committed append into an error.
Before this PR: add/delete changed the live set before persistence, and compaction could race with append. A flusher retry could expose duplicated source epochs under a new part ID.
After this PR: failed publication keeps the prior live set, and serialized compaction preserves committed records.
Verification: six focused tests passed, including failed add/delete, ambiguous-write rejection, and concurrent append/compaction with restart. Independent source review passed; CI is pending.
This does not claim exhaustive power-loss correctness; existing snapshot directory-sync behavior is outside this change. Performance measurements and screenshots are not applicable.