refactor: share installed producer and publication contracts - #643
Merged
Merged
Conversation
…ed-producer-plan-contract
…-plan-contract # Conflicts: # control_plane/src/query_plan.rs # crates/asap_types/Cargo.toml # data_plane/tests/clickhouse_differential_e2e.rs
…ed-producer-plan-contract
…cer-plan-contract # Conflicts: # docs/design_docs/summary-catalog-sds-architecture.md
zzylol
changed the base branch from
refactor/shared-query-plan-contract
to
main
September 11, 2026 14:56
zzylol
marked this pull request as ready for review
September 11, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed collector, transmission, and publication contracts must be usable by runtime components without importing control-plane compiler definitions.
This moves their existing wire structures and runtime validation into
asap_types. Control-plane compilation, deployment decisions, and accuracy-budget allocation remain in the control plane; existing imports retain compatibility re-exports. Data-plane consumers use the shared contracts directly.Before this PR: installed producer and publication types belonged to the compiler. Publication validation also confused slide cadence with stored state extent.
After this PR: producers and consumers share one contract, and a 60-second full-window state emitted every 10 seconds passes publication validation using its stored extent.
Verification: 83 shared-type tests, 726 control-plane tests, 1,109 data-plane tests, and the enhanced sliding-layout publication regression passed. Independent ownership review passed.
Stacked on #634. Existing duplicated collector configuration fields are preserved for compatibility and still require a separate catalog-consistency cleanup. No performance claim; screenshots are not applicable.