Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricsQL value rollups retain metric names, but installed ASAP readouts returned only population labels. A real VictoriaMetrics quantile comparison therefore reported 40 missing and 40 extra series despite acceptable numeric error.
This change reads metric identity from the shared Catalog snapshot for per-entity materializations. Quantile/max readouts retain it; count/rate and other readouts remove it. Logical min/max/avg over an external subquery follow the same MetricsQL rule. PromQL output and spatial reductions retain their existing semantics. Catalog descriptors and summary payloads are not copied.
Before this PR:
quantile_over_time(0.9, data[1h])lost__name__="data"on the ASAP branch.After this PR: installed MetricsQL value rollups preserve that identity, including inside a composed DAG. Missing catalog identity fails closed. Arithmetic still applies its own label matching and name-removal rules.
Verification: all 1,097 data-plane unit tests passed, including per-entity versus spatial quantile labels and temporal subDAG language differences. The pre-fix mismatch was observed against VictoriaMetrics v1.126.0. A post-fix full process rerun and independent review are pending; this PR makes no performance claim. Behavior follows VictoriaMetrics rollup semantics.
Stacked on #617. This does not add the MetricsQL
keep_metric_namesmodifier or claim full MetricsQL compatibility.