Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restored UnivMon states must use the same update mode as the backend accumulator. Valid terminal-mode sketchlib bytes otherwise pass decoding but are incompatible with subsequent standard updates and merges.
Use sketchlib's public compatibility accessor at the accumulator decode boundary, before publishing or updating the reconstructed state. The check reuses the library contract rather than duplicating its wire format.
Before this PR: a terminal-mode state could enter the standard accumulator.
After this PR: decoding rejects it; standard and reset-empty states remain accepted.
Verification: five focused backend tests pass, including terminal rejection, empty reset, serialization, merge and four catalog-bound readouts. Tested in isolated sibling checkouts against ProjectASAP/asap_sketchlib#139 commit
c0de315; the shared library checkout was not changed.Draft, stacked on #617. Requires sketchlib #139, whose CI is green but GitHub review is still required. This branch cannot pass ordinary main-library CI until that dependency is merged. No performance claim.