feat: retain selected SQL DAGs in installed precompute plans - #618
Merged
Merged
Conversation
…contract' into feat/clickhouse-table-population
…auto-materialization
zzylol
changed the base branch from
feat/clickhouse-table-population
to
main
September 11, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL publication previously retained materialization configs and QueryPlan nodes but discarded the selected Planner semantic DAG. Preserve that DAG in PrecomputePlan with the actual materialization and query-node bindings recorded during relational lowering.
PromQL and SQL now use one backend placement builder. Planner node IDs remain separate from summary and query identities; publication retains maintenance inputs, exact subtree boundaries, and the installed query sink. Remove an unused descriptor-copy pass because catalog validation already checks those bindings.
Validation: all 719 control-plane library tests pass, including the SQL mapping assertions. The real ClickHouse mixed process E2E passes after atomic installation, filtered backfill, summary readout, and exact-branch composition (1.43 s). Automatic materialization construction and full workload acceleration remain follow-up work; this change makes no performance claim.
Stacked on #614 for typed SQL source/population/time binding.