Share precompute installation contracts and catalog validation - #613
Merged
Merged
Conversation
…/shared-precompute-plan-contract
…/shared-precompute-plan-contract
zzylol
changed the base branch from
refactor/shared-executable-plan-contract
to
main
September 11, 2026 00:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime installation depended on compiler-owned
PrecomputePlanDTOs and catalog validation. Move that contract intoasap_typesso the compiler and data plane consume the same definitions without making the compiler their owner.asap_types::precompute_plannow ownsPrecomputePlan, its envelope, ingest/state-schema/producer contracts, deterministic constructors, and catalog consistency checks. Existing control-plane paths re-export the shared types; data-plane installation and ingest reference them directly. Schema IDs, serialization, validation behavior, and placement decisions remain unchanged.Before: the data plane imported its precompute installation contract from the physical compiler. After: the control plane selects and builds a shared contract, and the data plane validates and consumes it.
Verification: all 68 physical-compiler tests passed, including catalog mismatch rejection, materialization schema validation, shared snapshots, and backend-local/collector projections. All 10 data-plane active-plan lifecycle and concurrent snapshot tests passed. Performance and visual evidence are not applicable to this ownership-only change.
Stacked on #608. QueryPlan and transmission/collector DTO ownership remain separate follow-ups. This preserves current operator limitations and does not claim new execution coverage.