Reject maintenance updates without an implemented evaluator - #610
Merged
Merged
Conversation
zzylol
changed the base branch from
fix/bound-maintenance-commit-state
to
main
September 11, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production maintenance adapter treated
SummaryAggasSummaryMerge, ignoring its target family and update expression. For example, a count aggregation receiving a sum state containing 7 returned that same sum state instead of evaluating the count.Reject a non-source
SummaryAgguntil a typed update evaluator is available. An already computed source still enters through its materialization binding, and homogeneousSummaryMergedependencies continue to execute. Document the distinction between DAG traversal and implemented operators.Before: an unsupported summary transformation could be published as if it had executed. After: it fails explicitly instead of silently reusing input state under a different materialization identity.
Verification: all six maintenance-runtime tests passed, including the count-over-sum regression, shared dependencies, unsupported operators, bounded receipts, and publication retries. Performance and visual evidence are not applicable.
Stacked on #607. This closes a correctness hole; it does not implement general summary-over-summary transformations. A typed update/readout evaluator remains required for those operators.