Reject summary joins until keyed staging is available - #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production maintenance adapter treated
SummaryJoinas an accumulator merge. A join has keyed relational semantics and may require synchronized inputs;AggregateCore::merge_withcannot implement it. Plans containing this node could therefore publish a valid-looking but incorrect summary.Remove the unsafe mapping so
SummaryJoinfollows the existing explicit unsupported-operator failure path until the staged keyed join runtime is installed.Validation: inherited maintenance runtime failure/no-commit coverage; this is a one-arm dispatch correction.