Execute typed sliding-window layouts in the precompute worker - #583
Merged
Merged
Conversation
zzylol
force-pushed
the
feat/runtime-window-layouts
branch
from
September 10, 2026 16:55
021153e to
d81b471
Compare
zzylol
force-pushed
the
feat/sliding-window-layout-candidates
branch
from
September 10, 2026 17:13
886db4d to
a587572
Compare
zzylol
force-pushed
the
feat/runtime-window-layouts
branch
from
September 10, 2026 17:14
d81b471 to
b88897f
Compare
zzylol
changed the base branch from
feat/sliding-window-layout-candidates
to
main
September 10, 2026 17:28
zzylol
force-pushed
the
feat/runtime-window-layouts
branch
from
September 10, 2026 17:28
b88897f to
fac4cca
Compare
zzylol
added a commit
that referenced
this pull request
Sep 10, 2026
* Add costed sliding-window materialization layouts (#580) * Execute selected sliding window layouts in workers (#583) * Execute ClickHouse joins in the shared query DAG (#569) * feat(clickhouse): execute SQL joins in the shared query DAG * fix: consume canonical planner lifecycle contract * fix(clickhouse): validate each join input coverage * chore: pin merged planner join contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control plane can select pane or fully materialized sliding-window layouts, but the worker previously stored one slide-sized pane for every plan. That made
FullWindowa metadata-only choice and also conflated query slide with physical pane width.This change makes the selected layout drive runtime behavior. Pane and hierarchical layouts store one non-overlapping base pane using the declared pane width.
FullWindowfans each input into every overlapping semantic window and closes one complete state at each slide. Raw samples and incoming sketch states use the same layout rules; counter deltas are calculated once before full-window fanout.Validation:
cargo check -p data_planecargo test -p data_plane full_window_layout_materializes_each_overlapping_slide --lib