Conversation
Contributor
Author
|
Superseded by #589, which ports the typed ClickHouse exact-leaf and mixed SummaryStore join/project behavior into the shared language-neutral QueryPlan DAG without the former SQL-specific plan/catalog layers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A ClickHouse SQL query could previously use either an ASAP summary plan or whole-query ClickHouse fallback. It could not execute one planned subtree from SummaryStore, execute another exact subtree in ClickHouse, and compose both through the published query DAG.
What
ExternalSqlLeafto the single publishedQueryPlanDAG.DateTime64.How
The control plane matches every external artifact against the complete canonical
KeepPreAsapsubtree and its fingerprint. The data plane snapshots one active physical generation, fetches ClickHouse leaves, reads summary leaves bySummaryDefinitionId, and executes the parent relational DAG locally. Missing artifacts, incomplete coverage, schema drift, external errors, or unsupported shapes fall back to the original whole SQL query.Before this PR
A ratio query with one accelerated input and one unsupported input fell back entirely to ClickHouse.
After this PR
The accelerated input is read from the real SummaryStore, the unsupported input is executed as an exact ClickHouse subtree, and ASAPQuery joins both typed relations and evaluates the final projection locally in the same QueryPlan DAG.
Verification
cargo check -p control_plane -p data_plane --all-targetsHuman review
Reserved for human reviewers.