Publish the authoritative summary catalog with physical plans - #567
Merged
Merged
Conversation
zzylol
changed the base branch from
refactor/stable-post-asap-bindings
to
main
September 10, 2026 15:00
zzylol
force-pushed
the
refactor/publish-authoritative-catalog
branch
from
September 10, 2026 15:00
fcfb778 to
2d05cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The control plane already owns the authoritative
SummaryCatalog, but two publication paths passed separate plans toBackendClient, which rebuilt a second catalog from duplicated precompute definitions. That allowed descriptor identity and generation metadata to drift before installation.Before this PR
post_physical_plan_typedacceptedPrecomputePlan,TransmissionPlan, andQueryPlanseparately, derived a catalog inside the transport client, rebound cloned plans, and omitted the catalog chosen by the compiler. The compatibility replanner also advertised a collector producer even though it installs backend-local state and publishes noCollectorPlan.After this PR
Every production publication path assembles one
PhysicalPlanPublicationand passes that authoritative bundle topost_catalog_plan_typed.BackendClientonly validates and transports the supplied catalog and its plan projections. Catalog derivation remains confined to the legacy compatibility adapter, which now models its precompute work as backend-local and therefore does not manufacture a collector producer.Example
A ClickHouse compilation now publishes
bundle.sdstogether with the exact precompute, transmission, and query plans that reference that snapshot. The client cannot silently replace it with a catalog inferred from legacy materialization DTOs.Verification
cargo check -p control_plane --all-targetscargo test -p control_plane --lib catalog_publication_posts_canonical_document_without_legacy_bytescargo test -p control_plane --lib backend_push(15 passed)git diff --checkDepends on #564.
ClickHouse migration surface: construct the language-neutral
PhysicalPlanPublicationfrom the compiler-ownedSummaryCatalog,PrecomputePlan,TransmissionPlan, and unifiedQueryPlan. External exact execution stays represented as typed query DAG nodes; no language-specific plan catalog, sidecar, orExecutableQueryPlanis required.