fix: fall back for unsafe pooled raw counter state - #528
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Collector-free raw counter producers pool different time series into one accumulator. Two series at the same timestamp with independent resets can produce 10 instead of the independent-series total 15, yet be served as warm results.
After this PR
Backend-local planning routes affected rate/increase query roots to exact fallback while retaining other supported workload summaries. Counter-only snapshots deduplicate this exact alternative before cost quoting. Validation rejects previously generated raw-counter artifacts before they can become active; distributed precomputed counter envelopes remain supported.
Validation: the new safety regression failed before the compiler fix; 662 control-plane unit tests and both compatibility process tests pass. A worker regression demonstrates the pooled reset/timestamp failure. Process checks verify native forwarding for instant/range counter queries, retained warm siblings, and rejected-artifact installation leaves the active generation unchanged. The forwarding mock is a sentinel, not a Prometheus numerical oracle.