fix(query): honor exact accuracy requests - #507
Merged
Merged
Conversation
3 tasks
zzylol
added
area: data plane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348.
Adds a validated
X-ASAP-Accuracy: exact|approximaterequest contract to instant and range PromQL endpoints. Exact requests now enter the central router even when the configured metric axis is SketchStore, so they bypass approximate warm summaries and select the Gorilla archive. Approximate remains backward-compatible and warm-first.Also adds an instant routed-result API so response provenance reports the engine that actually answered rather than the configured storage axis.
Tests:
cargo test -p data_plane accuracy_header_parses_explicit_contract_and_rejects_typoscargo test -p data_plane exact_accuracy_header_bypasses_warm_tier_for_archivecargo test -p data_plane exact_accuracy_header_routes_range_query_to_archivecargo test -p data_plane invalid_accuracy_header_returns_bad_requestcargo fmt --checkThis PR is intentionally left open and unmerged.